Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(action-popover): add missing import to fix broken story #5731

Merged
merged 2 commits into from
Jan 6, 2023

Conversation

edleeks87
Copy link
Contributor

Proposed behaviour

Adds ActionPopoverMenuButton import to ActionPopover story

Current behaviour

ActionPopoverMenuButton not imported in ActionPopover story

Checklist

  • Commits follow our style guide
  • Storybook added or updated if required

QA

  • Tested in CodeSandbox/storybook
  • Add new Cypress test coverage if required
  • Carbon implementation matches Design System/designs
  • UI Tests GitHub check reviewed if required

Additional context

Testing instructions

Check story now loads in stroybook

The following CodeSandbox is an example of the broken behaviour.
You can see the new behaviour by looking at the version in the comment by codesandbox[bot].

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 5, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0856f87:

Sandbox Source
carbon-quickstart Configuration
carbon-quickstart-typescript Configuration
carbon-quickstart PR

@cypress
Copy link

cypress bot commented Jan 5, 2023



Test summary

4043 0 9 0Flakiness 0


Run details

Project carbon
Status Passed
Commit 0856f87
Started Jan 6, 2023 2:18 PM
Ended Jan 6, 2023 2:24 PM
Duration 06:24 💡
OS Linux Debian - 11.4
Browser Chrome 106

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@tomdavies73 tomdavies73 self-requested a review January 5, 2023 16:08
@edleeks87 edleeks87 merged commit 3a1ade8 into master Jan 6, 2023
@edleeks87 edleeks87 deleted the add-missing-import-act-pop-story branch January 6, 2023 14:28
@carbonci
Copy link
Collaborator

carbonci commented Jan 9, 2023

🎉 This PR is included in version 112.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants